nice -n huge_num true by oech3 · Pull Request #10213 · uutils/coreutils

oech3 · 2026-01-13T10:48:20Z

github-actions · 2026-01-13T11:29:03Z

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

src/uu/nice/src/nice.rs

github-actions · 2026-01-13T15:54:35Z

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

sylvestre · 2026-01-13T21:53:21Z

tests/by-util/test_nice.rs

+fn test_nice_huge() {
+    new_ucmd!()
+        .args(&[
+            "-n",


Only positive overflow is tested. Should add a test for negative overflow (e.g., -999...9) to ensure both clamping directions work.

Negative is root test, would not work on the CI.
...
Oh yes. It should work with permission denied.

github-actions · 2026-01-14T00:59:09Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

src/uu/nice/src/nice.rs

sylvestre · 2026-01-17T16:19:07Z

src/uu/nice/src/nice.rs

i think moving it into a function could help with readability

Is this operation duplicated at somethere?

tests/by-util/test_nice.rs

codspeed-hq · 2026-01-17T16:49:40Z

Merging this PR will degrade performance by 52.55%

❌ 34 regressed benchmarks
✅ 248 untouched benchmarks
⏩ 38 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Memory	`sort_general_numeric[200000]`	23.6 MB	43.2 MB	-45.37%
❌	Memory	`sort_numeric_utf8_locale`	4.2 MB	8.8 MB	-52.55%
❌	Memory	`sort_mixed_c_locale`	2.6 MB	3 MB	-12.17%
❌	Memory	`sort_long_line[160000]`	716.7 KB	981.4 KB	-26.98%
❌	Memory	`sort_german_c_locale`	3.6 MB	5.3 MB	-33.11%
❌	Memory	`sort_ascii_utf8_locale`	5.6 MB	6.2 MB	-9.9%
❌	Memory	`sort_mixed_utf8_locale`	2.6 MB	3.5 MB	-25.41%
❌	Memory	`sort_reverse_locale[500000]`	21.6 MB	27.5 MB	-21.64%
❌	Memory	`sort_numeric[500000]`	48.7 MB	79.2 MB	-38.49%
❌	Memory	`sort_unique_utf8_locale`	3.8 MB	4.6 MB	-18.99%
❌	Memory	`sort_key_field[500000]`	32.8 MB	51.8 MB	-36.61%
❌	Memory	`sort_german_de_locale`	3.6 MB	5.3 MB	-33.11%
❌	Memory	`sort_ascii_c_locale`	6.1 MB	8.3 MB	-26.89%
❌	Memory	`sort_dictionary_order[500000]`	29.7 MB	42 MB	-29.38%
❌	Memory	`sort_unique_locale[500000]`	36.9 MB	39.8 MB	-7.07%
❌	Memory	`sort_reverse_utf8_locale`	2.6 MB	3 MB	-11.96%
❌	Memory	`sort_mixed_data[500000]`	25.8 MB	27.1 MB	-4.8%
❌	Memory	`sort_accented_data[500000]`	25.5 MB	28.3 MB	-9.94%
❌	Memory	`sort_ascii_only[500000]`	25.5 MB	28.3 MB	-9.9%
❌	Memory	`sort_case_insensitive[500000]`	16.3 MB	16.9 MB	-3.34%
...	...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

_{Comparing oech3:nice-huge (5d9567a) with main (4bfbbdd)²}

38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (b3ad96f) during the generation of this report, so 4bfbbdd was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

github-actions · 2026-01-17T18:00:34Z

GNU testsuite comparison:

GNU test failed: tests/tail/follow-name. tests/tail/follow-name is passing on 'main'. Maybe you have to rebase?

github-actions · 2026-01-17T20:59:30Z

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

tests/by-util/test_nice.rs

github-actions · 2026-01-17T21:45:41Z

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

github-actions · 2026-01-17T22:03:19Z

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

src/uu/nice/src/nice.rs

tests/by-util/test_nice.rs

github-actions · 2026-01-18T04:52:49Z

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

github-actions · 2026-01-18T11:12:23Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

github-actions · 2026-01-18T12:35:50Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

oech3 changed the title ~~Nice huge~~ nice -n huge_num true Jan 13, 2026

oech3 force-pushed the nice-huge branch 2 times, most recently from eec8ae2 to ae0c818 Compare January 13, 2026 10:50

oech3 mentioned this pull request Jan 13, 2026

tests: nice -n 9999999999999999999999999999999999999999999999999999999999999… coreutils/coreutils#170

Closed

sylvestre reviewed Jan 13, 2026

View reviewed changes

src/uu/nice/src/nice.rs Outdated Show resolved Hide resolved

oech3 force-pushed the nice-huge branch 2 times, most recently from 4ce1311 to 7a75ddd Compare January 13, 2026 15:42

oech3 force-pushed the nice-huge branch from 7a75ddd to d7f458d Compare January 13, 2026 16:11

sylvestre reviewed Jan 13, 2026

View reviewed changes

oech3 force-pushed the nice-huge branch 2 times, most recently from fae9d13 to 0166306 Compare January 14, 2026 00:47